-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get GitHub issues from dependency repo #3295
Conversation
Can you supply an example request? I tried |
I think you need to write it like |
Hello! Please rebase, as the following commit 6046273 has reorganized our file structure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can go in, and we can do the rest in follow-ups (including tests).
Issue This PR Addresses
Fixes #2827
Type of Change
Description
This PR adds the whole GitHub issue thing to collect issues that are considered newcomer friendly.
A couple of details
This doesn't use Redis, at all. I tried to use Redis at first, but it seems that using it is somewhat redundant when the
githubInformationRequestor
is used. The reason I use this is to minimize the number of requests as possible when there are concurrent requests to the same resource. If we program this naively, when there are two or more requests really close to each other, all of those requests will ask essentially the same information, and thus we would be wasting requests.I will file a couple of issues to address some stuff that have to be changed:
Steps to test the PR
dependency-discovery
folder.pnpm dev
.GET https://localhost:10500/github/@babel/core
Checklist