Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Telescope overview and remove broken links #3286

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

tcvan0707
Copy link
Contributor

Issue This PR Addresses

Fixes #3180

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR is going to update the Overview page of Telescope by removing broken links, and adding the alternative source for our Planet.

Steps to test the PR

  • Change your current directory to /src/docs: cd src/docs
  • Run pnpm start
  • Go to localhost:4631 on your web browser

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 22, 2022

@@ -32,14 +32,14 @@ various "feed" technologies (RSS, Atom, CDF) to allow blog posts from different
platforms to be aggregated into a single page that was constantly updated with
the latest posts by people within a particular community.

[Written in Python by Jeff Waugh and Scott James Remnant](https://people.gnome.org/~jdub/bzr/planet/devel/trunk/),
Written in Python by Jeff Waugh and Scott James Remnant,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the link ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It directs us to 404 Not Found Page, and the content of this link I assume that it's already in this

aserputov
aserputov previously approved these changes Mar 22, 2022
@@ -20,7 +20,7 @@ something unique to "me."
To better enable the discovery of blogs within our community, we set up an open
source blog [Planet](<https://en.wikipedia.org/wiki/Planet_(software)>): an aggregated
feed of blog posts from Seneca faculty and students working on open source in a
single page. Our blog Planet currently lives at [http://zenit.senecac.on.ca/~chris.tyler/planet/](http://zenit.senecac.on.ca/~chris.tyler/planet/).
single page. Our blog Planet currently lives at [https://telescope.cdot.systems/planet](https://telescope.cdot.systems/planet).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
single page. Our blog Planet currently lives at [https://telescope.cdot.systems/planet](https://telescope.cdot.systems/planet).
single page. Our blog Planet currently lives at [Planet CDOT](https://telescope.cdot.systems/planet).

@tcvan0707 tcvan0707 self-assigned this Mar 22, 2022
Copy link
Contributor

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot speak for the Vietnamese page, aside from that, everything else is good!

@JerryHue
Copy link
Contributor

@tcvan0707, I'll be rebasing your branch from GitHub and then I will merge it.

	* Update original overview

	* Update overview in Vietnamese version

	* Update overview.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Telescope Overview docs and remove broken links
6 participants