refactor eslint configuration

[DukeManh]

I try my best to refactor our shared ESlint configuration.

Changes made:

• Since we publish @senecacdot/eslint-config-telescope as a package, other eslint configure can extend it just like airbnb-config, for example. Other configuration doesn't have to go into overrides
• Use EcmaVersion 2021
• Use recommended react-native config
• Install SuperTest as main dependency instead of dev, following ESlint recommendation
• Fix Eslint hangs #3245 by changing eslint file pattern from **/* (which might include outside files) to ./**/*
• Add 'ts,tsx' to file import resolver
• Use .gitignore as a .eslintignore (so cool)
• Use '@typescript-eslint/eslint-plugin' in src/web only
• Use '@eslint-plugin-react-native' in src/mobile only

[gitpod-io]

[DukeManh]

The ESLint test is expected to fail because it's still using the old config.

[cindyorangis]

Just a nit but @ precedes alpha letters

[cindyorangis]

Same here

[cindyorangis]

The ESLint is failing but it's expected due to the tools/eslint/index.js changes in this PR

telescope/tools/eslint/index.js

Lines 14 to 16 in 4d411c6

	'import/resolver': {
	node: {
	extensions: ['.js', '.jsx', '.ts', '.tsx'],

This import/resolver will resolve the 155 errors. To pass ESLint locally, change this line to

"@senecacdot/eslint-config-telescope": "workspace:1.0.1",

[DukeManh]

Thanks @cindy.
Or you can manually link eslint: cd <subdir> && pnpm link ./<relativepath-to-eslint>

[cindyorangis]

Err you tagged angry-raccoon-python-developer-cindy. Also good to know the pnpm link method. Knowing CLI commands makes things shorter :)

[DukeManh]

lol, those names are always taken

[cindyorangis]

Unfortunately, I don't have an SEO-friendly name. Maybe when I'm married

[JiaHua-Zou]

I tried rerunning the CI. It looks like the eslint is failing.

[DukeManh]

I tried rerunning the CI. It looks like the eslint is failing.

See @cindyledev's comment above

[DukeManh]

Rebased.

[humphd]

eslint in CI is unhappy

[DukeManh]

@humphd, because it's using [email protected], once this goes in we'll release a new version.

[menghif]

You can increase the version of eslint-config-telescope here. I don't think we need to do it in a separate PR

[DukeManh]

What's the appropriate version of the package do you think.

[humphd]

1.1.0 of 1.0.2, either is fine.

[DukeManh]

Ok I updated the version, I assume it will be automatically published? Then, we can trigger a Renovate bot for bump v1.0.1 -> v1.1.0 in sub-packages.

[humphd]

Correct. Merging on master will update it.