-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Banner image placeholder and fallback background #3190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool, I love it. A few things I notice.
@humphd, I'm running this again and the images fail to load. Do you know what this error is? |
I'm not 100% sure. Is that Firefox? Do you have a Service Worker on localhost:4444 that's interfering somehow (try changing port)? |
It's on any browser I try. Looks like something was changed on master recently that make the image service have CORS issue. I rebased and have the issue. I filed #3212 |
This is currently blocked by #3212, which makes it hard to test. |
}; | ||
|
||
// Define a series of sizes, and let the browser figure out which one to use | ||
function createSrcset(imageSrc: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice touch.
c92da46
to
81ef64c
Compare
I'm wondering if we might need to come to a consensus if we're ignoring Eslint tests until #3228 has been merged. |
@rclee91 I think that's fine, and we can fix things that we catch when the checks are working properly. |
81ef64c
to
3064216
Compare
3064216
to
86fbaf4
Compare
It's interesting that ESLint recommends |
86fbaf4
to
1453600
Compare
1453600
to
dd7c1fe
Compare
dd7c1fe
to
bdffe65
Compare
Issue This PR Addresses
Fixes #2925
Test
disable cache
, and choose one of thethrottling
options.Screenshot
2022-03-12.15-15-44.mp4