About page and fixing some ESLint problems by import react package #3167

tpmai22 · 2022-03-10T22:28:00Z

Issue This PR Addresses

Fixed #2859

Type of Change

Bugfix: Change which fixes an issue
New Feature: Change which adds functionality
Documentation Update: Change which improves documentation
UI: Change which improves UI

Description

Add the About page to our mobile app

Steps to test the PR

Open my PR in Gitpod
cd src/mobile
Run pnpm start
Refer to mobile docs on choosing testing device

Checklist

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Android.Emulator.-.Pixel_4_API_32_5554.2022-03-11.10-16-44.mp4

gitpod-io · 2022-03-10T22:28:02Z

src/mobile/package.json

src/mobile/src/screens/AboutScreen.jsx

TueeNguyen · 2022-03-11T02:53:00Z

src/mobile/src/screens/AboutScreen.jsx

+    alignItems: 'center',
+  },
+  scrollView: {
+    width: '80%',


how about 90% - 95%, there is some unnecessary padding

I just feel like this will be a bit delegant from my pov but I need more though on this @Andrewnt219

src/mobile/src/screens/AboutScreen.jsx

TueeNguyen · 2022-03-11T02:55:49Z

Nit: the scroll bar could be more transparent

tpmai22 · 2022-03-11T04:26:10Z

Fixing most of the stuff except the margin and update on how it look in the description

TueeNguyen · 2022-03-11T04:39:10Z

The brightness in the middle makes my eyes hurt :)

tpmai22 · 2022-03-11T15:19:40Z

The brightness in the middle makes my eyes hurt :)

I try to be fancy but I guess I will keep it simple from now

Kevan-Y

Having some marginBottom here would be good.

src/mobile/package.json

Kevan-Y · 2022-03-11T15:41:30Z

src/mobile/src/components/Banner/Banner.jsx

@@ -1,3 +1,4 @@
+import React from 'react';


I thought we had a fix before to allow us not having ESlint to show an error when react not imported

it is still so I wonder

TueeNguyen · 2022-03-11T20:02:35Z

Looks ok to me, needs another rebase @tpmai22

nguyenhung15913 · 2022-03-14T00:20:58Z

Great job !!
But I wonder should we use the original design of text instead:

Kevan-Y · 2022-03-15T01:19:30Z

Great job !! But I wonder should we use the original design of text instead:

Nice catch probably we should. It can be done in a follow-up issue. Since this has been sitting here for a long period and is close to being merged.

Kevan-Y · 2022-03-15T01:20:43Z

@tpmai22 Could you rebase your branch

- stop() now return Promise - Add some fixes to tests - Add shutdown() functions to Satellite.stop() - Change Elastic mock to reinitialize beforeEach

tpmai22 · 2022-03-18T19:38:02Z

@rclee91 we can merge this

Kevan-Y · 2022-03-18T21:25:11Z

Yeah a rebase, and can be merged. Create a follow issue to apply font-family to all the screen

RC-Lee · 2022-03-18T21:41:20Z

Waiting for tests to rerun, since it failed the previously

vercel bot deployed to Preview March 10, 2022 22:28 View deployment

tpmai22 requested review from Kevan-Y, nguyenhung15913 and humphd and removed request for Kevan-Y March 10, 2022 22:37

tpmai22 self-assigned this Mar 11, 2022

tpmai22 added area: React Native type: enhancement New feature or request review: easy labels Mar 11, 2022

tpmai22 added this to the 2.8 Release milestone Mar 11, 2022

TueeNguyen reviewed Mar 11, 2022

View reviewed changes

src/mobile/package.json Outdated Show resolved Hide resolved

TueeNguyen reviewed Mar 11, 2022

View reviewed changes

src/mobile/src/screens/AboutScreen.jsx Outdated Show resolved Hide resolved

src/mobile/src/screens/AboutScreen.jsx Outdated Show resolved Hide resolved

TueeNguyen reviewed Mar 11, 2022

View reviewed changes

tpmai22 force-pushed the issue-2859 branch from 5e45b5f to 6ace11b Compare March 11, 2022 04:24

vercel bot deployed to Preview March 11, 2022 04:24 View deployment

tpmai22 requested a review from TueeNguyen March 11, 2022 04:25

tpmai22 force-pushed the issue-2859 branch from 6ace11b to 1433441 Compare March 11, 2022 15:18

vercel bot deployed to Preview March 11, 2022 15:18 View deployment

tcvan0707 previously approved these changes Mar 11, 2022

View reviewed changes

Kevan-Y requested changes Mar 11, 2022

View reviewed changes

tpmai22 dismissed tcvan0707’s stale review via 94a68d3 March 11, 2022 17:12

tpmai22 force-pushed the issue-2859 branch from 1433441 to 94a68d3 Compare March 11, 2022 17:12

vercel bot deployed to Preview March 11, 2022 17:13 View deployment

tpmai22 requested a review from Kevan-Y March 11, 2022 17:19

tpmai22 requested a review from tcvan0707 March 11, 2022 17:19

tpmai22 modified the milestones: 2.8 Release, 2.9 Release Mar 11, 2022

tpmai22 force-pushed the issue-2859 branch from 94a68d3 to 7c1c756 Compare March 11, 2022 21:54

vercel bot deployed to Preview March 11, 2022 21:54 View deployment

tpmai22 force-pushed the issue-2859 branch from 7c1c756 to 1c0f9d1 Compare March 11, 2022 21:55

vercel bot deployed to Preview March 11, 2022 21:56 View deployment

nguyenhung15913 mentioned this pull request Mar 14, 2022

Adding footer for mobile app's about screen #3203

Closed

tpmai22 force-pushed the issue-2859 branch from 1c0f9d1 to 9a724a1 Compare March 15, 2022 02:02

vercel bot deployed to Preview March 15, 2022 02:02 View deployment

Kevan-Y previously approved these changes Mar 17, 2022

View reviewed changes

nguyenhung15913 previously approved these changes Mar 17, 2022

View reviewed changes

Change stop method to close all db connections (Seneca-CDOT#3162)

0d072ca

- stop() now return Promise - Add some fixes to tests - Add shutdown() functions to Satellite.stop() - Change Elastic mock to reinitialize beforeEach

tpmai22 force-pushed the issue-2859 branch from 9a724a1 to 0d072ca Compare March 18, 2022 19:21

vercel bot deployed to Preview March 18, 2022 19:21 View deployment

cindyorangis dismissed stale reviews from nguyenhung15913 and Kevan-Y via 0d072ca March 18, 2022 19:56

RC-Lee requested review from Kevan-Y and nguyenhung15913 March 18, 2022 21:17

Kevan-Y approved these changes Mar 18, 2022

View reviewed changes

tcvan0707 approved these changes Mar 18, 2022

View reviewed changes

RC-Lee merged commit 505ed86 into Seneca-CDOT:master Mar 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

About page and fixing some ESLint problems by import react package #3167

About page and fixing some ESLint problems by import react package #3167

tpmai22 commented Mar 10, 2022 •

edited

Loading

gitpod-io bot commented Mar 10, 2022

TueeNguyen Mar 11, 2022

tpmai22 Mar 11, 2022

TueeNguyen commented Mar 11, 2022

tpmai22 commented Mar 11, 2022

TueeNguyen commented Mar 11, 2022

tpmai22 commented Mar 11, 2022

Kevan-Y left a comment

Kevan-Y Mar 11, 2022

tpmai22 Mar 11, 2022

TueeNguyen commented Mar 11, 2022 •

edited

Loading

nguyenhung15913 commented Mar 14, 2022

Kevan-Y commented Mar 15, 2022

Kevan-Y commented Mar 15, 2022

tpmai22 commented Mar 18, 2022

Kevan-Y commented Mar 18, 2022

RC-Lee commented Mar 18, 2022

About page and fixing some ESLint problems by import react package #3167

About page and fixing some ESLint problems by import react package #3167

Conversation

tpmai22 commented Mar 10, 2022 • edited Loading

Issue This PR Addresses

Type of Change

Description

Steps to test the PR

Checklist

gitpod-io bot commented Mar 10, 2022

TueeNguyen Mar 11, 2022

Choose a reason for hiding this comment

tpmai22 Mar 11, 2022

Choose a reason for hiding this comment

TueeNguyen commented Mar 11, 2022

tpmai22 commented Mar 11, 2022

TueeNguyen commented Mar 11, 2022

tpmai22 commented Mar 11, 2022

Kevan-Y left a comment

Choose a reason for hiding this comment

Kevan-Y Mar 11, 2022

Choose a reason for hiding this comment

tpmai22 Mar 11, 2022

Choose a reason for hiding this comment

TueeNguyen commented Mar 11, 2022 • edited Loading

nguyenhung15913 commented Mar 14, 2022

Kevan-Y commented Mar 15, 2022

Kevan-Y commented Mar 15, 2022

tpmai22 commented Mar 18, 2022

Kevan-Y commented Mar 18, 2022

RC-Lee commented Mar 18, 2022

tpmai22 commented Mar 10, 2022 •

edited

Loading

TueeNguyen commented Mar 11, 2022 •

edited

Loading