Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ESLint for Satellite and fix ESlint errors #3151

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Mar 9, 2022

Issue This PR Addresses

Fixes #3144

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes ESLint configuration for Satellite and fixes ESLint errors.

Steps to test the PR

pnpm i
pnpm lint

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2022

parserOptions: {
ecmaVersion: 13,
},
plugins: ['anti-trojan-source', 'jest'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep this plugin: anti-trojan-source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have it in @senecacdot/eslint-config-telescope

@tpmai22 tpmai22 added this to the 2.8 Release milestone Mar 9, 2022
@tpmai22
Copy link
Contributor

tpmai22 commented Mar 9, 2022

@menghif let's rebase when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure ESLint for Satellite
5 participants