-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add star field with GitHub contributors #3149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbelokon this is really, really creative. I love having a node to "Processing" in Telescope, since Seneca worked for so many years on Processing.js.
I want to figure out where to put this. I'm not convinced that it's appropriate on the landing page of the site. I don't want to remove the dynamic images, which was an important design feature of another Telescope cohort.
Because this is primarily about Telescope's development vs. use, does it belong in the About page or Docs?
It would be great if we have the startfield, but we still need to keep the dynamic images (which we are currently have now). Why don't you try to put the startfield on top of the images? |
I followed your instructions and I changed the I was able to get this running locally and it looks amazing. I had this running for like 15 minutes and I hit an API rate limit
|
This is very creative @dbelokon. We need to think about where we can put this, whether the about page or dedicated |
Thank you!
Thinking about it, it is true that the star field focuses on Telescope project contributors, so moving it somewhere would be better. I would like to move it to the About page, so I don't have to figure out how Docusaurus can bundle |
Whoops~! That's a huge typo 😅 I corrected it to
I think the API rate-limiting happens only when you refresh the page several times, requesting the list of contributors so many times. I am not sure why you reached a limit if you only left the page running. Well, with something as complicated as this, it is expected to have bugs 😂 I also edited your comment and removed the previous revision to hide the IP address shown. That's your public IP, and we are in a public repo, so we better hide it 👍 |
I think this would be interesting. I didn't think of using the dynamic image as the background for the star field. But when I was reading @humphd reasoning to move this somewhere else, I thought it is better to do that instead of shoving it in the hero banner. Very cool idea, though! |
@dbelokon you want to push this in |
@dbelokon, this is very cool! I just noticed some strange flickering, where some profile pictures would appear somewhat big and then disappear. Do you know the reason why? I also updated your original PR message to include the newest changes :) |
It looks much better on the About Page. As @JerryHue mentioned, I also see the flickering I can't seem to figure out what's causing it. Side note: I can't get over how you managed to get something working using a video from 2016 + React + GitHub API like wow. I love visuals and this is just amazing. Gives me https://www.youtube.com/watch?v=WAJ_T2rcKhU @humphd vibes |
I wonder if this should go at the top vs. bottom of the About page? It seems wasted "below the fold." |
@dbelokon how are we heading with this ? |
@dbelokon, I notice some avatars flickering a few seconds in. |
Done! @rclee91 😁 |
pnpm-lock.yaml
Outdated
@@ -125,7 +125,7 @@ importers: | |||
'@babel/preset-env': 7.16.11_@[email protected] | |||
'@babel/preset-react': 7.16.7_@[email protected] | |||
'@babel/preset-typescript': 7.16.7_@[email protected] | |||
'@senecacdot/eslint-config-telescope': link:tools/eslint | |||
'@senecacdot/eslint-config-telescope': 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #3200, I added the no-linking
option to pnpm, which won't link any package. But we wanted to link eslint so I linked eslint manually with pnpm link
command, pnpm-lock
is updated, but when we install a new dependency which this pr does, pnpm sees the no-linking
option and unlinks it.
I realized this today and make a fix for it in #3228. We should get it in before Dianna lands this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and ignoring the ESLint failures for now
Some ESLint stuff has updated again, wait for a bit to rebase and pick up on those changes
@dbelokon |
oh oopsie, sorry, @rclee91 , going to do that today |
I think this one needs a rebase only, there are other issues already filed. @dbelokon |
@dbelokon, it's safe to delete |
@JerryHue, @AmasiaNalbandian, I have rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested again, everything works
I'll merge when the checks are finished! |
Checks are done. Merging! |
Issue This PR Addresses
#2982 (there are other ideas on the thread that I would like to implement)
Type of Change
Description
This PR shows a prototype for a special starfield that will appear in the About page.
Steps to test the PR
git fetch dbelokon
, you have to have my repo as a remote repository)git checkout starfield
).pnpm dev
). I recommend trying withenv.staging
as the.env
.localhost:8000/about/
page 😄Checklist