Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove user service deployment from gitpod yml #3104

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

joelazwar
Copy link
Contributor

@joelazwar joelazwar commented Mar 4, 2022

Issue This PR Addresses

Since we've recently removed the User service in favor of Supabase, we've cleaned most if not all traces of it in the repo.

I've been using gitpod quite a bit, so I noticed that the config file hasnt been modified to reflect the above change.

just a small change to amend it

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2022

@humphd humphd requested a review from DukeManh March 4, 2022 18:22
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why API services are inaccessible through URLs recently. API Host is running on Port 8443 but services at '/v1/service' are not found. Maybe, it has something to do with you PR that put Traefik behind Nginx, @humphd ?

@aserputov aserputov merged commit 8a854d0 into Seneca-CDOT:master Mar 4, 2022
@DukeManh
Copy link
Contributor

DukeManh commented Mar 4, 2022

It's my fault that Pnpm installation is missing from our gitpod setup because Pnpm is shipped with the workspace/node container, not workspace/base. I removed it in a recent PR.
I am working on fixing that and adding GitPod Local Companion to make our app running on Gitpod using localhost, and there will be no more replacing localhost URLs with the GitPod ones. But I got stuck with the services on port 8443 not found.

@cindyorangis cindyorangis added this to the 2.8 Release milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants