Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colour palette in docs #3065

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix colour palette in docs #3065

merged 1 commit into from
Feb 28, 2022

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Feb 27, 2022

Issue This PR Addresses

Fixes #2938

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes the missing colours for the palette in the docs and reorganizes it with tabs for Light and Dark mode.

Screen Shot 2022-02-26 at 11 27 17 PM

Steps to test the PR

  • Change directory to /src/docs: cd src/docs
  • Start the server: pnpm start
  • Visit localhost:4631 in browser

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Add Tabs for Light and Dark palette
@gitpod-io
Copy link

gitpod-io bot commented Feb 27, 2022

Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool way of displaying the colours here. I didn't think of using a React component

Comment on lines +118 to +119
</TabItem>
</Tabs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: how come Prettier doesn't complain about the formatting? For example, I can see the indents are off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know

@cindyorangis cindyorangis added the type: documentation (docs) Improvements or additions to documentation label Feb 27, 2022
@menghif menghif merged commit 18c40c5 into Seneca-CDOT:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Palette not Showing Properly
3 participants