-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ElasticSearch to 8.0 #3026
Conversation
- Updating package.json ES dependency to 8.0 - Updating docker/docker-compose.yml to ES 8.0 - Disabling new ES default security settings - Refactor: Taking out 'type' from 'indexer' and 'search' - Refactor: Commenting out ES-mock test instances Co-authored-by: Josue <[email protected]>
Based on what you've written above, it seems like it's too soon to move to 8.0, no? If we don't have mocks, we don't have tests. Seems like a deal breaker? |
I think we should wait until elasticsearch-mock is compatible with Elasticsearch v8 before we update Elasticsearch. I don't want to go in naked with no mocks or tests. |
Maybe @rclee91 will send a PR upstream to fix it, who knows... |
elastic/elasticsearch-js-mock#24 just landed, updating the mock to support v8. |
I've started to test this with Satellite. |
Hello! Please rebase, as the following commit 6046273 has reorganized our file structure! |
@rclee91 Hi, can you give me an update for this. Do you need help or more reviewers? |
closing until after autocomplete has been fully implemented. |
Issue This PR Addresses
#2913
Type of Change
Description
Co-authored-by: @manekenpix
Steps to test the PR
To run on
development
pnpm install
pnpm start
. Sometimes if it can't find ElasticSearch, you'd have to stop it (ctrl + c
) and then runpnpm start
again.Problems
Currently for the new security features we have it set to
false
. Details of the conversation can be found in the issue at this commentThe changes for
createError
in the Searchquery.js
is related to issue [Satellite] Cannot set property statusCode of Error which has only a getter #2755 , which can be fixed by two different PRs, because this is an Error from ElasticSearch, to be fixed by Fixes #2755: Update ElasticSearch URL #2990 and a crash fromhttp-errors
, to be fixed by Satelitte PR#64 (Yes, I'm also asking for reviews please).The problem is that in development mode, ElasticSearch sometimes can't recognize the url
127.0.0.1
and tries to send an ElasticSearch Error, which causes the crash when we try tocreateError
from it.The current code changes in
query.js
can be taken off once at least one of these two fixes are implemented.I've tried to upgrade ES to 8.0 in Satellite and run the tests there as well. I get this error on the ES-mock tests:
An issue for ES-mock on this was made a while ago. I don't think this is fixable from our end.
So, unfortunately, I had to temporarily comment out the Search tests that required ES-mock to run.
We'd have to either wait for ES-Mock to update, or find a new way to test Search. Maybe mock the whole module.