-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Issue-2767: Windows installation steps to use expo-cli with android studios #2920
Conversation
aaec284
to
6afa537
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that you added pictures. They help a lot
It took me so long to get this to launch on my PC. I feel bad for anyone who might go through the same problem... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! There's missing punctuation at the end of some paragraphs and I would also add a blank line between the paragraphs and the images.
added description to images added formatting fixes added formatting fixes added formatting fixes fixed typo
00dbe1e
to
5321731
Compare
|
||
##### Windows Installation | ||
|
||
1. [Download Android Studio](https://developer.android.com/studio) using the standard options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These steps have been mentioned in the docs that we put on line 44. Also setting up the global variable path point the SDK
build tool should be indicate as a note
since most of the team members did not have to go through it to have the project running at their local machine. I think it is just a bug on your local machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how many people tried this on windows without problems, lets check that out and see maybe its just my end...
@AmasiaNalbandian I regconized that I leave a review but forgot to submit it ! Above is my thought on the change maybe we can figure it out in another PR |
Issue This PR Addresses
fixes #2767
Type of Change
Description
I was not able to launch expo-cli so easily on my PC so I wrote better instructions for Windows. The link provided says the environment variables are only required for MacOS and Linux users but that is not the case, so I outlined all the steps to do that part.
Steps to test the PR
Checklist