Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue-2767: Windows installation steps to use expo-cli with android studios #2920

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

AmasiaNalbandian
Copy link
Contributor

@AmasiaNalbandian AmasiaNalbandian commented Feb 14, 2022

Issue This PR Addresses

fixes #2767

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

I was not able to launch expo-cli so easily on my PC so I wrote better instructions for Windows. The link provided says the environment variables are only required for MacOS and Linux users but that is not the case, so I outlined all the steps to do that part.

Steps to test the PR

  • This ones simple so please just review my steps and see if they make sense. Let me know if you have a different experience on windows.
  • If you go to files changed, then click the 3 dots for the file, select view file and then scroll down you can see how it will look in the read.me format on the docs. This will help review.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2022

cindyorangis
cindyorangis previously approved these changes Feb 14, 2022
Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you added pictures. They help a lot

@AmasiaNalbandian
Copy link
Contributor Author

I love that you added pictures. They help a lot

It took me so long to get this to launch on my PC. I feel bad for anyone who might go through the same problem...

Copy link
Contributor

@menghif menghif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There's missing punctuation at the end of some paragraphs and I would also add a blank line between the paragraphs and the images.

src/docs/docs/tools-and-technologies/react-native.md Outdated Show resolved Hide resolved
added description to images

added formatting fixes

added formatting fixes

added formatting fixes

fixed typo
@menghif menghif merged commit c7facec into Seneca-CDOT:master Feb 15, 2022
@TueeNguyen TueeNguyen added this to the 2.7 Release milestone Feb 15, 2022

##### Windows Installation

1. [Download Android Studio](https://developer.android.com/studio) using the standard options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps have been mentioned in the docs that we put on line 44. Also setting up the global variable path point the SDK build tool should be indicate as a note since most of the team members did not have to go through it to have the project running at their local machine. I think it is just a bug on your local machine

Copy link
Contributor Author

@AmasiaNalbandian AmasiaNalbandian Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how many people tried this on windows without problems, lets check that out and see maybe its just my end...

@tpmai22
Copy link
Contributor

tpmai22 commented Feb 15, 2022

@AmasiaNalbandian I regconized that I leave a review but forgot to submit it ! Above is my thought on the change maybe we can figure it out in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: React Native type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching expo-cli is difficult without instructions
6 participants