Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning dependencies in ./tools #2916

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Pinning dependencies in ./tools #2916

merged 1 commit into from
Feb 14, 2022

Conversation

TueeNguyen
Copy link
Contributor

@TueeNguyen TueeNguyen commented Feb 14, 2022 •
edited
Loading

Issue This PR Addresses

Fixes #2725

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • I was thinking of adding rangeStrategy to pin but I don't think it'll work, docs
  • Pinning all dependencies in ./tools for renovate to work

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2022

@Kevan-Y Kevan-Y added area: tools dependencies Pull requests that update a dependency file labels Feb 14, 2022
Kevan-Y
Kevan-Y previously approved these changes Feb 14, 2022
View reviewed changes
DukeManh
DukeManh previously approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let's hope Renovate will pickup dependencies in 'tools'

humphd
humphd previously approved these changes Feb 14, 2022
View reviewed changes
cindyorangis
cindyorangis previously approved these changes Feb 14, 2022
View reviewed changes
@TueeNguyen TueeNguyen dismissed stale reviews from cindyorangis, humphd, and DukeManh via b10b7e1 February 14, 2022 17:26
@TueeNguyen
Copy link
Contributor Author

Just rebased, thanks for the reviews.

@menghif menghif merged commit b7f546b into Seneca-CDOT:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevan-Y Kevan-Y Kevan-Y approved these changes

@cindyorangis cindyorangis cindyorangis approved these changes

@AmasiaNalbandian AmasiaNalbandian Awaiting requested review from AmasiaNalbandian

@DukeManh DukeManh Awaiting requested review from DukeManh

@humphd humphd Awaiting requested review from humphd

Assignees

@TueeNguyen TueeNguyen

Labels
area: tools dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renovate not working under './'tools'
6 participants
@TueeNguyen @humphd @cindyorangis @DukeManh @Kevan-Y @menghif