Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2762: Indicate better build information in build-header #2907

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

tpmai22
Copy link
Contributor

@tpmai22 tpmai22 commented Feb 13, 2022

Issue This PR Addresses

Fix #2761

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Adding commit messgae in build header for better information about the build

Steps to test the PR

  • Change autodeploymentUrl in src\api\status\public\js\build-log\check-build-status.js
const autodeploymentUrl = (path) => `//dev.telescope.cdot.systems/deploy${path}`;  
  • Allow all connectSrc in src\api\status\src\server.js
connectSrc: ["'self'", "*"]

-Change directory tp api service and run the front end

cd src/api/status
pnpm dev

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

image

@gitpod-io
Copy link

gitpod-io bot commented Feb 13, 2022

@cindyorangis cindyorangis added this to the 2.7 Release milestone Feb 13, 2022
@cindyorangis cindyorangis added the area: dashboard Related to Telescope's dashboard (the page that has stats) label Feb 13, 2022
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this happening. A few things to fix.

src/api/status/public/js/build-log/build-header.js Outdated Show resolved Hide resolved
src/api/status/public/js/build-log/build-header.js Outdated Show resolved Hide resolved
src/api/status/src/views/builds.hbs Outdated Show resolved Hide resolved
src/api/status/public/js/build-log/build-header.js Outdated Show resolved Hide resolved
@tpmai22
Copy link
Contributor Author

tpmai22 commented Feb 13, 2022

@humphd I made some small changes and updated the screenshot in the description

humphd
humphd previously approved these changes Feb 13, 2022
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Andrewnt219
Andrewnt219 previously approved these changes Feb 14, 2022
Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍.

@Andrewnt219
Copy link
Contributor

@tpmai22 can you do a rebase instead of merge?

@humphd
Copy link
Contributor

humphd commented Feb 14, 2022

cc @menghif or @TueeNguyen, if you need help with this rebase.

@tpmai22
Copy link
Contributor Author

tpmai22 commented Feb 14, 2022

@Andrewnt219 @humphd one more reviews and we are good to merged it

@tpmai22 tpmai22 merged commit f3fa1ba into master Feb 14, 2022
@tpmai22 tpmai22 deleted the issue-2761 branch February 14, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use better message for build header
5 participants