Created test for dependency-discovery service #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TueeNguyen
added
the
area: dependency visualization
JerryHue
previously approved these changes
Feb 14, 2022
humphd
requested changes
Feb 14, 2022
| const { app } = require('../src'); | ||
|
|
||
| jest.mock('process', () => ({ | ||
| cwd: () => 'src/api/dependency-discovery', |
There was a problem hiding this comment.
Agree with @JerryHue , let's mock the file for the dependency list, so we can write tests against it.
|
|
||
| module.exports = { | ||
| ...baseConfig, | ||
| setupFiles: ['<rootDir>/src/api/dependency-discovery/jest.setup.js'], |
There was a problem hiding this comment.
Include the root-level jest.setup.js too.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. @rclee91 and @JiaHua-Zou had to deal with something similar in other tests where we didn't do this. They can guide you.
TueeNguyen
force-pushed
the
dependency-test
branch
from
a3cdd78 to
60d5604
Compare
TueeNguyen
force-pushed
the
dependency-test
branch
from
60d5604 to
b6967fb
Compare
|
@JerryHue I changed the |
TueeNguyen
force-pushed
the
dependency-test
branch
from
b6967fb to
de91938
Compare
Where are we at with this test failure? |
I reran the checks and it passed, will look into this |
RC-Lee
previously approved these changes
Feb 16, 2022
TueeNguyen
force-pushed
the
dependency-test
branch
from
de91938 to
16376ae
Compare
RC-Lee
approved these changes
Feb 17, 2022
JerryHue
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #2826
Type of Change
Description
dependency-discoveryservice, and healthcheck of the service tostatusSteps to test the PR
pnpm installpnpm test src/api/dependency-discoveryChecklist