Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify footer ~add links, and changed copyright label #2902

Merged
merged 1 commit into from
Feb 13, 2022
Merged

modify footer ~add links, and changed copyright label #2902

merged 1 commit into from
Feb 13, 2022

Conversation

sancodes
Copy link
Contributor

@sancodes sancodes commented Feb 12, 2022

Issue This PR Addresses

Docusaurus footer needs to be updated, fixes #2881

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Modify the Footer:

  • Added new labels for links, that successfully directs to proper site when clicked.
  • Changed Footer's Copyright label
  • Changes made passes local test, with screenshot attached below and no updates on documentation as the documentation is still being worked on at the moment.

Screen Shot 2022-02-11 at 5 11 22 PM

Steps to test the PR

With Environment Set up to direction to see where the change has been added:

  • Clone the Telescope repository
  • Install pnpm globally: npm install -g pnpm
  • Install the dependencies: pnpm install (this will also install the dependencies in the Docusaurus website)
  • Change directory to src/docs (this is where all the code lives for our Docusaurus website): cd src/docs
  • Start the app: pnpm start
  • Visit localhost:4631 in your browser.
  • Scroll all the way to the bottom of the page, to where the Footer is.
  • You will be able to see various labels that directs to its sites.
  • You can also see updated Footer Copyright label.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 12, 2022

Copy link
Contributor

@TueeNguyen TueeNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sancodes Thanks for doing this

Can you rebase instead of merging? You can reset your branch to the commit before your 1st merge commit and do:

  1. update your fork
  2. git checkout master
  3. git pull origin master
  4. git checkout footer-enhancement
  5. git rebase master

If you have further trouble with rebasing, I'm willing to help

@sancodes
Copy link
Contributor Author

@TueeNguyen

so I ran

  1. git reset --hard f6ea868
  2. git checkout master
  3. git pull origin master
  4. git checkout footer-enhancement
  5. git rebase master
  6. git push origin footer-enhancement

Then while pushing I get this error.

Screen Shot 2022-02-12 at 3 26 32 PM

Maybe I did something wrong. Can you help me on this? thank you kindly.

@TueeNguyen
Copy link
Contributor

You're doing it correctly, the SHA commit after you rebase is different than the one you have in this PR, so just do a git push origin footer-enhancement -f

This way you're gonna force push it

@sancodes
Copy link
Contributor Author

@TueeNguyen

Seems like it worked, Thank you.

Did that meet your requirement?

@TueeNguyen
Copy link
Contributor

I just checked your fork, you haven't fetch and merge your fork. Update it and do the steps again without doing git reset

@sancodes
Copy link
Contributor Author

@TueeNguyen
I just went to the forked version of telescope on my github, clicked on the button that said, 'fetch and merge'
then followed the steps.

I dont know if I messed up anything. Please let me know, if everything is working fine.

],
},
],
copyright: `Copyright © ${new Date().getFullYear()} My Project, Inc. Built with Docusaurus.`,
copyright: `Copyright © ${new Date().getFullYear()} <br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Thank you so much

@cindyorangis cindyorangis merged commit bcea109 into Seneca-CDOT:master Feb 13, 2022
@cindyorangis cindyorangis added this to the 2.7 Release milestone Feb 15, 2022
@sancodes sancodes deleted the footer-enhancement branch March 7, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docusaurus Anything related to Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docusaurus footer needs to be updated
3 participants