-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify footer ~add links, and changed copyright label #2902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sancodes Thanks for doing this
Can you rebase instead of merging? You can reset your branch to the commit before your 1st merge commit and do:
- update your fork
git checkout master
git pull origin master
git checkout footer-enhancement
git rebase master
If you have further trouble with rebasing, I'm willing to help
so I ran
Then while pushing I get this error. Maybe I did something wrong. Can you help me on this? thank you kindly. |
You're doing it correctly, the SHA commit after you rebase is different than the one you have in this PR, so just do a This way you're gonna force push it |
Seems like it worked, Thank you. Did that meet your requirement? |
I just checked your fork, you haven't |
@TueeNguyen I dont know if I messed up anything. Please let me know, if everything is working fine. |
], | ||
}, | ||
], | ||
copyright: `Copyright © ${new Date().getFullYear()} My Project, Inc. Built with Docusaurus.`, | ||
copyright: `Copyright © ${new Date().getFullYear()} <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Thank you so much
Issue This PR Addresses
Docusaurus footer needs to be updated, fixes #2881
Type of Change
Description
Modify the Footer:
Steps to test the PR
With Environment Set up to direction to see where the change has been added:
Checklist