Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2786 - Added steps to test in template for PRs #2787

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

AmasiaNalbandian
Copy link
Contributor

Issue This PR Addresses

Fixes #2786

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI
  • Development Enhancement

Description

Most of us are new to telescope, or new to some areas of telescope. Most of us want to review PRs but have no idea how. I added a section to have contributors add the steps to reproduce their fix, or build their new features. This will allow us to have more reviewers and ship code faster.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2022

@AmasiaNalbandian
Copy link
Contributor Author

@sirinoks This will greatly help us document how to build most of the code in Telescope for your Issues.

cc @JerryHue

Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@tpmai22
Copy link
Contributor

tpmai22 commented Feb 1, 2022

@AmasiaNalbandian I think encourage people to includes screenshots might be a good idea too

@HyperTHD HyperTHD merged commit 529f175 into Seneca-CDOT:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Helping the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'steps to test' in PR templates
5 participants