-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2nd draft for Registering an Image #2784
Conversation
on: | ||
push: | ||
branches: | ||
- 'issue-1743' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very interested in this GitHub Container Registry stuff. Were you able to push an image from your personal issue-1743 branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, but having that allows the workflow to trigger when I push it to my fork for testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. One more thing I notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this and see what it does.
NOTE: we'll need to make a change within src/api/feed-discovery/**
for this to do anything once it lands. Maybe update one of the deps?
@TDDR can you squash, rebase, and reword this?
|
ba00920
Issue This PR Addresses
Fixes #1743
Type of Change
Description
This is my second draft of this after attempting to use a different workflow in a previous iteration. I have tried multiple different ways to try and get the buider to go into a sub directory instead of using the Dockerfile in the root with varying results
I think the version in this PR is the proper way to go about it, but it's not supported yet
I could be wrong but I'm not sure what else to try.