Fix signup page crash #2754
Merged
Fix signup page crash #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humphd
requested changes
Jan 27, 2022
.gitpod.yml
Outdated
| @@ -9,11 +9,13 @@ tasks: | |||
| eval $(gp env -e API_URL=$(gp url 3000)) | |||
| eval $(gp env -e WEB_URL=$(gp url 8000)) | |||
| eval $(gp env -e API_HOST=$(gp url 8443)) | |||
| eval $(gp env -e SSO_URL=$(gp url 8081)) | |||
There was a problem hiding this comment.
I don't think this file should be changing as part of this PR, should it?
There was a problem hiding this comment.
I wanted to make the singup flow works for people who might review this PR using Gitpod.
humphd
previously approved these changes
Jan 27, 2022
.gitpod.yml
Outdated
| eval $(gp env -e SERVICES="status image auth search posts feed-discovery users redis elasticsearch login firebase") | ||
|
|
||
| sed -r \ | ||
| -e "s@(.+=)http://localhost:8000(/[^ ]*)*@\1$WEB_URL\2@g" \ | ||
| -e "s@(.+=)http://localhost:3000(/[^ ]*)*@\1$API_URL\2@g" \ | ||
| -e "s@(.+=)http://localhost:8081(/[^ ]*)*@\1$SSO_URL\2@g" \ |
There was a problem hiding this comment.
I was just surprised to see this change, since it is based on my other PR, right?
There was a problem hiding this comment.
No, I just happened to have the same idea.
HyperTHD
previously approved these changes
Jan 27, 2022
|
This needs a rebase and can go in after that merge conflict is fixed. |
humphd
previously approved these changes
Jan 28, 2022
humphd
approved these changes
Jan 28, 2022
aserputov
approved these changes
Jan 31, 2022
|
@humphd can we merge this one ? |
|
@aserputov go for it, click |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the signup page crash due to
useEffectinfinite loop in 'SignUp.tsx'Issue This PR Addresses
Type of Change
Description
Checklist