Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Didn't lint properly, this is a fix #2740

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Didn't lint properly, this is a fix #2740

merged 2 commits into from
Jan 25, 2022

Conversation

sirinoks
Copy link
Contributor

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Fixes prettier errors

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Sorry I didn't know .md files could ruin everything x_x

@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2022

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your local environment is out of date:

Checking formatting...
[warn] src/api/status/src/js/github-stats.js
[warn] src/web/src/student-quotes.js
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

Please run pnpm install and then pnpm prettier again to see if you can fix this.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for fixing.

@sirinoks sirinoks merged commit 15a5803 into Seneca-CDOT:master Jan 25, 2022
@sirinoks sirinoks deleted the linted branch January 25, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants