-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved build log page for issue 2622 #2669
Improved build log page for issue 2622 #2669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reworking this code in #2653 too, so we can take this and I can incorporate it into mine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a rebase and you are good to merge
08f387e
@nguyenhung15913 correct, we don't want to do this. It creates a new merge commit, merging |
So now I have to revert the commit and rebase right ? |
If you rebase, it should get rid of the merge commit. But yes, you could also revert and then rebase. |
awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
Issue This PR Addresses
fixes #2622
Type of Change
Description
Screenshot
How to test locally
From the root directory
https://dev.telescope.cdot.systems/deploy/status
orhttps://telescope.cdot.systems/deploy/status
instead ofautodeploymentUrl('status')
in thecheckBuildStatus()
insrc/api/status/public/js/build-log/api.js
connectSrc
insrc\api\status\src\server.js
so that it won't have error related to CSPcd ./src/api/status
andpnpm run dev
. Then go to http://localhost:1111/v1/status/build.Checklist