Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auto deployment links #2656

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

JerryHue
Copy link
Contributor

@JerryHue JerryHue commented Jan 14, 2022

Issue This PR Addresses

Fixes #2521.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Update the consumer code for the status dashboard to present a more developer-friendly URL: from https://dev.telescope.cdot.systems:4000/status to https://dev.telescope.cdot.systems/deploy/status AND
https://dev.telescope.cdot.systems:4000/log to https://dev.telescope.cdot.systems/deploy/log.

Checklist

  • Quality: This PR builds and passes our npm test and works locally.
  • Tests: This PR does not require test as it does not change functionality.
  • Screenshots: This PR does not provide screenshots as it does not change UI.
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed.

Co-Authored-By: Qiwen Yu [email protected] (AKA @Qiwen-Yu)

@JerryHue JerryHue added this to the 2.5 Release milestone Jan 14, 2022
@JerryHue JerryHue self-assigned this Jan 14, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 14, 2022

tools/autodeployment/README.md Outdated Show resolved Hide resolved
DukeManh
DukeManh previously approved these changes Jan 14, 2022
Copy link
Contributor

@AmasiaNalbandian AmasiaNalbandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@JerryHue
Copy link
Contributor Author

I have rebased the branch. Let me know if we need anything else. @DukeManh, @AmasiaNalbandian, @humphd

humphd
humphd previously approved these changes Jan 17, 2022
DukeManh
DukeManh previously approved these changes Jan 17, 2022
@humphd
Copy link
Contributor

humphd commented Jan 17, 2022

@JerryHue land when ready!

Andrewnt219
Andrewnt219 previously approved these changes Jan 18, 2022
@JerryHue JerryHue dismissed stale reviews from Andrewnt219, DukeManh, and humphd via 08e7965 January 18, 2022 02:16
@JerryHue
Copy link
Contributor Author

JerryHue commented Jan 18, 2022

So, uh, because of another change to master, I had to rebase again... Should I force the squash and merge? I don't know if I have the permissions for it.

Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Squash and merge" is fine.

@JerryHue JerryHue merged commit 786dfa2 into Seneca-CDOT:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use /deploy vs :4000 for autodeployment links
5 participants