You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation Update: Change which improves documentation
UI: Change which improves UI
Description
Setted overflowY as hidden to avoid title container overflow.
overflow.mp4
Checklist
Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)
@irenejoeunpark Can we rebase this so it's ready for merge? :)
I have fixed all of the conflicts caused while rebasing, however I am getting error with the pnpm commands which blocks me to commit. I know it is not a good practice, but can I fix the conflicts by editing in github for this one?
@irenejoeunpark, fixing conflicts here would merge master in your branch, which is not what we want. If u have problems with your local environment, I'd recommend taking a look at our Gitpod docs and continue your work on there.
@irenejoeunpark, fixing conflicts here would merge master in your branch, which is not what we want. If u have problems with your local environment, I'd recommend taking a look at our Gitpod docs and continue your work on there.
Thanks Duke! @irenejoeunpark It seems easier but it really does make it messier. I will be around if you need help with this :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #2583
Type of Change
Description
Setted overflowY as hidden to avoid title container overflow.
overflow.mp4
Checklist