Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPU cores calculation for determining the number of concurrency workers #2206

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Apr 23, 2021

Issue This PR Addresses

Fixes #2120

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Added CPU calculation to optimize concurrency setup for jest tests for our CI and Release workflows.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@birtony birtony self-assigned this Apr 23, 2021
@birtony birtony added the area: CI/CD Continuous integration / Continuous delivery label Apr 23, 2021
@birtony birtony added this to the 2.0 Release milestone Apr 23, 2021
@birtony birtony requested review from humphd and manekenpix April 23, 2021 04:07
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, and I think we should do it, but it didn't affect overall build times at all (i.e., compare these runs to previous runs without the change). I had hoped it might make a difference.

@chrispinkney
Copy link
Contributor

Comparing this PRs checks to another PRs checks is funny. In some places it does better, in some places it does worse. Weird.

@birtony
Copy link
Contributor Author

birtony commented Apr 23, 2021

@chrispinkney @humphd yeah, I've had the same controversial results with testing the different number of workers for npm test, npm run jest-watch and npm run jest-update. The modifications proposed in the article @humphd found earlier did not improve the speed, but even made it worse in some cases on my machine...

@birtony birtony merged commit ff0d814 into master Apr 23, 2021
@birtony birtony deleted the issue2120-ci branch April 23, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak Jest configuration to make tests run faster
3 participants