Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dark mode palette #2205

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Update dark mode palette #2205

merged 1 commit into from
Apr 23, 2021

Conversation

yuanLeeMidori
Copy link
Contributor

Issue This PR Addresses

Fixes: #2047

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR is the last clean-up for gathering the use of dark mode palette.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@yuanLeeMidori yuanLeeMidori self-assigned this Apr 23, 2021
@yuanLeeMidori yuanLeeMidori added this to the 2.0 Release milestone Apr 23, 2021
chrispinkney
chrispinkney approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good! Testing using deployment and code looks excellent.

@yuanLeeMidori yuanLeeMidori merged commit 9040b9e into Seneca-CDOT:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@chrispinkney chrispinkney chrispinkney approved these changes

@humphd humphd Awaiting requested review from humphd

@rjayroso rjayroso Awaiting requested review from rjayroso

@tonyvugithub tonyvugithub Awaiting requested review from tonyvugithub

@PedroFonsecaDEV PedroFonsecaDEV Awaiting requested review from PedroFonsecaDEV

Assignees

@yuanLeeMidori yuanLeeMidori

Labels
area: front-end
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

Update palette of dark mode
3 participants
@yuanLeeMidori @chrispinkney @manekenpix