Advanced search

[huyxgit]

[huyxgit]

@humphd this question is a bit further when this advanced search component completed: should we wire up this search dialog to the searchButton on Nav bar instead of redirecting to search-page right away?

[humphd]

@huynguyez good question. At some point (later) we might want to have a way to search from the main page without moving over to this page. For now, let's have a way to get to the advanced search from the search page, but not have that be the default.

[huyxgit]

@HyperTHD

[izhuravlev]

@huynguyez do you need help? I can hop on a call in about 2 hours and work on this so we can merge it.

[huyxgit]

@izhuravlev sure, still problems with the dialog, state. What time?

[HyperTHD]

Just a preliminary review. There's stuff other stuff I need to look at but this is a few stuff I caught

[HyperTHD]

You're probably going to have to update the SearchProvider so that you can access a state toggle value similar to SearchHelp. Look at how SearchHelp's toggle value is implemented in SearchProvider.tsx for reference

[izhuravlev]

I can't input text into the search bar - sorry for the delay, we can stay on the call after the meeting and work on it till it's done

[huyxgit]

@HyperTHD I tried to store the state in global but it still same. any idea?

[huyxgit]

Not work when I store state in Context (search provider). But using states in local component is working as expected. Obviously this should be optimized later

[LuigiZaccagnini]

Small change.

[LuigiZaccagnini]

Instead of using black you can use #000000 instead.

[TueeNguyen]

Hi @huyxgit, any update on this work?

[AmasiaNalbandian]

There is work in progress on the branch right here:
https://github.com/AmasiaNalbandian/telescope/tree/issue-2110-advancedsearch

I have cherry picked the beginning code for the modal, and have made more progress by implementing the backend for the advanced search from the PR that was added here: #2617

I am going to close this PR as it is abandoned, and I have picked up the issue.