Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed commented out line in src/api/src/routes/logout.js#l51 issue #2193 #2198

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

BanJoeH
Copy link
Contributor

@BanJoeH BanJoeH commented Apr 21, 2021

Issue This PR Addresses

Fixes #2193

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@humphd
Copy link
Contributor

humphd commented Apr 21, 2021

This change looks good @BanJoeH. One thing I need you to do is to edit your initial comment to change issue ##2193 to Fixes #2193 so that GitHub auto-closes the issue when we merge this.

@yuanLeeMidori yuanLeeMidori requested a review from humphd April 21, 2021 19:09
@humphd humphd merged commit 29951b7 into Seneca-CDOT:master Apr 21, 2021
@humphd
Copy link
Contributor

humphd commented Apr 21, 2021

Thanks a lot, @BanJoeH, it's great to have you contribute to Telescope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stray commented line in logout.js
3 participants