Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2186: Signup Flow fails with feed-discovery #2188

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fixes #2186: Signup Flow fails with feed-discovery #2188

merged 2 commits into from
Apr 20, 2021

Conversation

HyperTHD
Copy link
Contributor

Issue This PR Addresses

This PR closes #2186

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

When the signup flow was demoed today, the discovery-feed portion was failing. An undefined url was returned. I suspect this was because the FEED_DISCOVERY_URL, was not defined in the Dockerfile, despite being defined in the docker-compose.yml, and web related stuff. I added the feed discovery url to the dockerfile as a result.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Dockerfile Show resolved Hide resolved
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HyperTHD HyperTHD merged commit 81ec1d4 into Seneca-CDOT:master Apr 20, 2021
@HyperTHD HyperTHD deleted the issue-2186 branch April 20, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signup flow fails with feed-discovery
4 participants