Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2157 - Align post content on mobile under 600px #2158

Merged
merged 3 commits into from
Apr 16, 2021
Merged

fixes #2157 - Align post content on mobile under 600px #2158

merged 3 commits into from
Apr 16, 2021

Conversation

Meneguini
Copy link
Contributor

@Meneguini Meneguini commented Apr 16, 2021 •
edited
Loading

Issue This PR Addresses

fixes #2157.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes the alignment of the post's content.
I painted the background to make it easier to visualize in the screenshot.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)
    Before:

1

After:
2

@PedroFonsecaDEV PedroFonsecaDEV changed the title This PR fixes #2157 fixes #2157 - Align post content on mobile under 600px Apr 16, 2021
@PedroFonsecaDEV PedroFonsecaDEV added area: front-end type: bug Something isn't working labels Apr 16, 2021
@PedroFonsecaDEV PedroFonsecaDEV added this to the 2.0 Release milestone Apr 16, 2021
PedroFonsecaDEV
PedroFonsecaDEV approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. @Meneguini
Thank you.

humphd
humphd approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Firefox, working well. Thanks for this.

@humphd humphd merged commit 87e479f into Seneca-CDOT:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@yuanLeeMidori yuanLeeMidori yuanLeeMidori approved these changes

@humphd humphd humphd approved these changes

@tonyvugithub tonyvugithub Awaiting requested review from tonyvugithub

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

Assignees

@Meneguini Meneguini

Labels
area: front-end type: bug Something isn't working
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

Align post content on mobile under 600px
4 participants
@Meneguini @humphd @yuanLeeMidori @PedroFonsecaDEV