Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix landing page on mobile #2150

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix landing page on mobile #2150

merged 1 commit into from
Apr 15, 2021

Conversation

PedroFonsecaDEV
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV commented Apr 15, 2021 •
edited
Loading

Issue This PR Addresses

Fixes #2149

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

The landing page wasn’t displaying 100vh on mobile. This PR fixes this issue.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@PedroFonsecaDEV PedroFonsecaDEV added this to the 2.0 Release milestone Apr 15, 2021
@PedroFonsecaDEV PedroFonsecaDEV self-assigned this Apr 15, 2021
@PedroFonsecaDEV PedroFonsecaDEV merged commit bf293f6 into Seneca-CDOT:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DukeManh DukeManh DukeManh approved these changes

@chrispinkney chrispinkney chrispinkney approved these changes

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@birtony birtony Awaiting requested review from birtony

@yuanLeeMidori yuanLeeMidori Awaiting requested review from yuanLeeMidori

Assignees

@PedroFonsecaDEV PedroFonsecaDEV

Labels
area: front-end
Projects
None yet
Milestone
2.0 Release
Development

Successfully merging this pull request may close these issues.

The landing page doesn’t display 100vh on mobile.
3 participants
@PedroFonsecaDEV @chrispinkney @DukeManh