Use Redis for auth service session storage in production #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
area: redis
Metropass
reviewed
Apr 12, 2021
| const passport = require('passport'); | ||
| const session = require('express-session'); | ||
| const RedisStore = require('connect-redis')(session); |
There was a problem hiding this comment.
Reading what express-session is, I assume we just pass in a new cookie with no options?
HyperTHD
approved these changes
Apr 13, 2021
birtony
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was waiting for Redis to get added to Satellite before I could do this, and now that it's here, I'm switch our auth service to use Redis-backed session storage in production. Similar to what we do now in the back-end.