Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to react testing library for FE tests #2122

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Apr 10, 2021

Issue This PR Addresses

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

With using @testing-library/react, I was able to create a snapshot test for the AboutFooter component, which didn't work with react-test-renderer. I suggest that we switch to the first one instead.I have also added jest-update script to launch tests and update any outdated snapshots.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@birtony birtony added this to the 2.0 Release milestone Apr 10, 2021
@birtony birtony self-assigned this Apr 10, 2021
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a few small things.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
humphd
humphd previously approved these changes Apr 11, 2021
Updated scripts

Mocked imported component
@birtony birtony dismissed stale reviews from PedroFonsecaDEV and humphd via 0aa3454 April 12, 2021 01:39
@birtony birtony force-pushed the react-testing-library branch from 019c984 to 0aa3454 Compare April 12, 2021 01:39
@birtony birtony merged commit 5269c1d into master Apr 12, 2021
@birtony birtony deleted the react-testing-library branch April 12, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants