Closes #2083: Migrate legacy accounts away from wiki #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispinkney
requested review from
humphd,
HyperTHD,
c3ho,
birtony and
izhuravlev
c3ho
previously requested changes
Apr 8, 2021
humphd
requested changes
Apr 8, 2021
| @@ -0,0 +1,68 @@ | |||
| const fetch = require('node-fetch'); | |||
There was a problem hiding this comment.
Should this live in tools/ vs. src/api/users/tools?
There was a problem hiding this comment.
@manekenpix and I had some discussion about this too, we weren't sure so we decided to leave it here and see what others thought.
It originally was made to help with testing the paginated GET route, but now it instead dumps users to a json file so perhaps tools/ is the better place after all.
humphd
requested changes
Apr 9, 2021
humphd
previously approved these changes
Apr 9, 2021
* Initial implementation of planet feed wiki migration tool * Removed satellite & migrated to console.log (and friends) instead * Added README, review fixes * Refactor README to be more a-temporal * Change feeds into string * Removed env.local
humphd
approved these changes
Apr 9, 2021
HyperTHD
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Josue [email protected]
Issue This PR Addresses
Closes #2083
Type of Change
Description
This tool fetches legacy users from the planet feed wiki list, parses them, and dumps to a JSON file for later use (in the parsing service).
How to test
gh pr checkout 2096cd src\api\users\tools\migratenpm installnpm startThe users are dumped to
src\api\users\tools\migrate\legacy_users.jsonChecklist