Add e2e test for signup flow in auth + user services #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
added
type: test
|
This needs a rebase on #2103 |
|
Depends on #2116. |
chrispinkney
approved these changes
Apr 13, 2021
HyperTHD
approved these changes
Apr 13, 2021
|
This is not blocked anymore, I have fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting really close to being able to support login + signup in the microservices. I wanted to get a complete e2e test written that would allow us to see if it's working properly.
This test won't pass yet, since it requires a few more pieces (authenticated routes, #2058, etc). However, I wanted to get it written before I forgot and while I had time.