CSS changes to author info section #2035
Conversation
| @@ -9,7 +9,12 @@ const useStyles = makeStyles((theme: Theme) => | |||
| display: 'flex', | |||
| flexDirection: 'column', | |||
| justifyContent: 'center', | |||
| borderLeft: '2.5px solid #707070', | |||
| marginBottom: '80vh', | |||
| opacity: '0.4', | |||
There was a problem hiding this comment.
I like the idea. But let's increase the opacity.
opacity: 0.6 or 0.7.
There was a problem hiding this comment.
@huynguyez you have an interesting idea, but could you do some research on how similar websites handle this and share some results with us in the PR description, please? I think this would help us come to a team decision. Right now it looks to me like opacity: 0.4 is too much, I would increase it a bit. In terms of the separator, I think we should maybe add some opacity to it and keep it, it helps identify the author info as a separate section from the content of the post. I wouldn't get rid of it. Let's take a look at how others handle such layouts and decide.
There was a problem hiding this comment.
I personally like the latest update. It seems to be a good compromise for both of your points @PedroFonsecaDEV @huynguyez
I think I agree with this too. It's a great idea I just don't think it fits well here. Also needs a rebase as the hyphen changes from Royce aren't included. |
|
Waiting on a rebase + more review, but looking close. |
|
@huynguyez, @rjayroso, @PedroFonsecaDEV let's review this one and merge if it's ready |
| borderLeft: '2.5px solid #707070', | ||
| [theme.breakpoints.up('lg')]: { | ||
| width: '22rem', | ||
| }, |
There was a problem hiding this comment.
Re-add the breakpoint to utilize the whitespace on larger screens.
|
@huynguyez is this ready for another review? |
|
@rjayroso an you please review? |
UPDATED
Closes #1995
Update:
with Left align in blog content, the info section placed on the right doesn't seem right. It's better on the left of the blog instead:
The vertical separator bar is unnecessary and made it looks just unsightly in modern day design, or if you guys wanna keep it, leave it thin and use lighter color.
or remove it and add more margin between blog content (example for Medium)
ALso about the Navigation menu, no matter what color you use, it will never pops out at first load + banner image in the current design.
My suggestion: Return it back to horizontal top, hidden when scroll down and visible when scroll up.