Closes Issue #1932: Added environment variables to prod's Docker file #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
requested changes
Mar 26, 2021
| @@ -33,7 +33,7 @@ if ( | |||
| type: FIREBASE_TYPE, | |||
| project_id: FIREBASE_PROJECT_ID, | |||
| private_key_id: FIREBASE_PRIVATE_KEY_ID, | |||
| private_key: FIREBASE_PRIVATE_KEY, | |||
| private_key: FIREBASE_PRIVATE_KEY.replace(/\\n/g, '\n'), // escape the newline characters so docker can properly parse the key | |||
There was a problem hiding this comment.
Why are there newline characters in it at all? It should be a single line of text.
There was a problem hiding this comment.
It is a single line of text but it does have newline characters in it. I was getting private key errors without this fix (that someone suggested on stackoverflow)
There was a problem hiding this comment.
In other files where we do this, we've been reading a file (cc @manekenpix, who has done this a bunch and probably has advice).
chrispinkney
force-pushed
the
issue-1932
branch
from
5f8dab9 to
3aa1840
Compare
|
Big thanks to @manekenpix who graciously spent some time to help me figure out how to get this mess working. |
chrispinkney
commented
Mar 28, 2021
humphd
requested changes
Mar 29, 2021
* Dev and Docker mode now working both locally and in prod environments * Overriding FIRESTORE_EMULATOR_HOST in jest.config.e2e.js to pass tests * Removed dotenv (no longer needed) * Using cross-env * Utilizing require instead of fs for firestore keys * Refactored firestore.js * Removed unused variables * Added comments, cleaned up key require in firestore.js, rebased
chrispinkney
force-pushed
the
issue-1932
branch
from
17a71a6 to
3a08048
Compare
humphd
approved these changes
Mar 30, 2021
manekenpix
approved these changes
Mar 30, 2021
Metropass
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Closes Issue #1932
Type of Change
Description
This PR adds the required environment variables for the Users MS to prod's Docker file. I added some test values and
console.log'd them after runningdocker-compose --env-file config/env.production up --buildand they all displayed just fine. Users should be set up and ready to go once we finally create a Firebase project for Telescope (don't quote me on this.)I also hardcoded an environment variable (
process.env.FIRESTORE_EMULATOR_HOST = 'localhost:8088')infirestore.jswhich allows developers to test locally when usingnpm run services:start firebaseandcd src/api/users && npm run devtogether. This environment variable is only injected when running in dev mode.To be completely honestly, it's hacky but I couldn't get get the dev version of the users ms to work when running via Docker, only when running using
npm run dev. I'd love to spend some time with someone to try and figure this out (as well as properly test prod), as it's worrisome that prod may not actually work, but it is at least set up with this PR.Checklist