-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature] Video Player Page #1168
Conversation
Big fan of the beta badge |
This is a really cool feature idea. A one stop shop for videos and livestreams of this awesome community! I'm really interested in the future backend portion of this PR. |
@smilegodly great to hear you're interested in doing the backend portion! I have no idea how it's going to work in the back so you'll have to lead the backend efforts. This will definitely need to be split up into multiple PRs, I'm just trying to put together an acceptable-looking frontend page here :P @agarcia-caicedo nice catch, I didn't even see that |
I'm really glad you started work on this. Adding "live" streaming is something I want to do this term with my new group. Some questions/feedback:
We should consider how and where to spec all this out. Probably trying to do it all in this PR isn't fair to you. Maybe more discussion should happen in #1026? |
My main question about this, is whether it's supposed to be to display livestreams or prerecorded videos, or maybe even both, since that would influence how the ui is designed |
When I originally started this, I actually used plyr and called it a As for the content areas, I'm not a designer so I initially planned for it to be more of a YouTube clone with 2/3 on the left being the iframe and 1/3 on the right as a playlist. The UI probably needs to be more thought out. Anyway, these are the things I would like for this feature are:
|
modified: src/frontend/package.json modified: src/frontend/src/components/Header/DesktopHeader.jsx modified: src/frontend/src/components/Header/MobileHeader.jsx new file: src/frontend/src/components/PlayerPage/PlayerPage.jsx new file: src/frontend/src/components/PlayerPage/index.js new file: src/frontend/src/pages/player.js
modified: src/frontend/src/components/Header/DesktopHeader.jsx modified: src/frontend/src/components/Header/MobileHeader.jsx modified: src/frontend/src/components/PlayerPage/PlayerPage.jsx
What I did:
Need help with:
I'm too scared to look at this on another screen so here's what it looks like on mine :) |
@cindyledev let's file separate bugs on things like "Twitch backend" and "YouTube backend" etc. Your list above is a good checklist of things we'll need. |
Okay, I'll undraft this PR for reviews. Coming back to this after a couple of hours and it's not as bad as I thought... Issues will be filed after I get some sort of feedback here |
@cindyledev I can help you with styling |
Issue This PR Addresses
Addresses #1026
Type of Change
Description
This is still in its early stages and will need help/feedback on design + backend. Starting small with YouTube videos since I think they're easier to work with and will iterate with follow-up PRs. Currently only frontend React components.
Checklist