Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Feeds page: connect feed deletion button to backend functionality #946

Closed
Silvyre opened this issue Apr 6, 2020 · 0 comments · Fixed by #933
Closed

My Feeds page: connect feed deletion button to backend functionality #946

Silvyre opened this issue Apr 6, 2020 · 0 comments · Fixed by #933
Assignees
@Silvyre
Labels
area: back-end area: front-end type: enhancement New feature or request

Comments

@Silvyre
Copy link
Contributor

Silvyre commented Apr 6, 2020

What would you like to be added:

The implementation of the feed deletion buttons on the My Feeds page (introduced by #933) must be completed, i.e. by invoking the to-be backend logic for feed deletion that is being developed by @c3ho and @Grommers00.

Why would you like this to be added:

This is one step towards ensuring that the My Feeds page is capable of facilitating a vital administration functionality.
@Silvyre Silvyre added type: enhancement New feature or request area: front-end labels Apr 6, 2020
@Silvyre Silvyre mentioned this issue Apr 7, 2020
Merged
8 tasks
@Silvyre Silvyre self-assigned this Apr 8, 2020
Silvyre added a commit that referenced this issue Apr 9, 2020
@Silvyre
Fix #746, #760, #946: enhance the My Feeds page (#933)
510f090 
* add form logic, help modal to My Feeds page

* fetch user feeds into separate form controls

* add delete feed buttons, refactor logic

* address review comments

* remove call to refresh window upon feed deletion

* refactor a useState call for consistency

* redirect non-logged-in users to 404 page without rendering My Feeds page

* add feed deletion logic to DeleteFeedDialogButton

* implement getUserFeeds() stop-gap

* fix DeleteFeedDialogButton props

* correct props destructuring in 3435b76

* remove commented-out proptypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silvyre Silvyre

Labels
area: back-end area: front-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #746, #760, #946: enhance the My Feeds page Silvyre/telescope
1 participant
@Silvyre