Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release command needs some fixes #704

Closed
humphd opened this issue Feb 11, 2020 · 0 comments · Fixed by #783
Closed

Release command needs some fixes #704

humphd opened this issue Feb 11, 2020 · 0 comments · Fixed by #783
Assignees
Labels
area: deployment Production or Staging deployment developer experience Helping the Developer Experience type: bug Something isn't working

Comments

@humphd
Copy link
Contributor

humphd commented Feb 11, 2020

I just did a release for 0.6.0, and it worked really well. For reference, here is what it looked like:

$ npm run release --dry-run

> @seneca/[email protected] release /Users/humphd/repos/telescope
> run.env release-it --

✔ npm run test-ci

🚀 Let's release @seneca/telescope (currently at 0.0.1)


Empty changelog

? Select increment (next version): Other, please specify...
? Please enter a valid version: 0.6.0

Empty release notes


Changeset:
M package.json

? Commit (Release 0.6.0)? Yes
? Tag (0.6.0)? Yes
? Push? Yes
? Create a release on GitHub (Release 0.6.0)? Yes
? Publish @seneca/telescope to npm? No
🔗 https://github.com/Seneca-CDOT/telescope/releases/tag/0.6.0
🏁 Done (in 171s.)

This generated a new GitHub Release, updated our package.json version, and pushed to GitHub.

Only 2 things that I can see didn't work:

  1. I used the --dry-run flag to test the process without actually doing it. But the way I'm passing args to the command doesn't seem to work, or the --dry-run flag is wrong (but docs talk about it)
  2. The changelog wasn't generated from the Git log. We should fix this, so we get automatic release notes. The docs talk about how to do it.
@humphd humphd added type: bug Something isn't working developer experience Helping the Developer Experience area: deployment Production or Staging deployment labels Feb 11, 2020
@humphd humphd self-assigned this Mar 3, 2020
humphd added a commit to humphd/telescope that referenced this issue Mar 3, 2020
humphd added a commit that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: deployment Production or Staging deployment developer experience Helping the Developer Experience type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants