Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent client from caching /status response #2515

Closed
Andrewnt219 opened this issue Nov 23, 2021 · 7 comments · Fixed by #2781
Closed

Prevent client from caching /status response #2515

Andrewnt219 opened this issue Nov 23, 2021 · 7 comments · Fixed by #2781
Assignees
@TueeNguyen
Labels
area: autodeployment Anything related to auto deployment area: web server Issues related to the web server type: enhancement New feature or request
Milestone
2.6 Release

Comments

@Andrewnt219
Copy link
Contributor

What would you like to be added:
Is related to #2486
Add Cache-Control header to endpoint /status in tools/autodeployment to prevent caching.

Why would you like this to be added:
Clients should always get the most up-to-date build status.
@Andrewnt219 Andrewnt219 added the type: enhancement New feature or request label Nov 23, 2021
@humphd humphd added area: autodeployment Anything related to auto deployment area: web server Issues related to the web server labels Nov 23, 2021
@mqnguyen5
Copy link
Contributor

Can I give this a shot?

@humphd
Copy link
Contributor

humphd commented Nov 29, 2021

Sure, pair it with other things to make something large enough for 0.4 (this is small).

@mqnguyen5
Copy link
Contributor

Will do, I already have another issue undergoing

@Andrewnt219
Copy link
Contributor Author

Oh wait, I think @manekenpix did this already.

@TDDR TDDR assigned TueeNguyen and unassigned mqnguyen5 Jan 20, 2022
@humphd humphd added this to the 2.6 Release milestone Jan 24, 2022
@humphd
Copy link
Contributor

humphd commented Jan 24, 2022

This still needs to happen.

@TueeNguyen
Copy link
Contributor

Hi @manekenpix, I went over some related PRs, you did mention adding Cache-Control header but you did not add right?

@manekenpix
Copy link
Member

@TueeNguyen I didn't add it.

@TueeNguyen TueeNguyen mentioned this issue Jan 30, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TueeNguyen TueeNguyen

Labels
area: autodeployment Anything related to auto deployment area: web server Issues related to the web server type: enhancement New feature or request
Projects
None yet
Milestone
2.6 Release
Development

Successfully merging a pull request may close this issue.

Added Cache-Control to build status header TueeNguyen/telescope
5 participants
@humphd @manekenpix @Andrewnt219 @TueeNguyen @mqnguyen5