-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit how a user becomes an admin #2153
Labels
Comments
humphd
added
type: enhancement
New feature or request
type: security
Security concerns
area: microservices
labels
Apr 15, 2021
|
8 tasks
8 tasks
@chrispinkney and @manekenpix started this work in #2239, and we can likely build on the initial PR there to get this done, once the users backend is in place. |
In #3030 I'm suggesting that we use GitHub OAuth with org/team membership to define our admins. Closing this in favour of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We have the concept of an
admin
role in the User and Auth services, in the front-end, etc. In Firebase it's a boolean,isAdmin: true|false
. We need to tighten how a user becomes an admin.You shouldn't be able to POST that data to the Users service (we should ignore it). The current system is too loose.
The text was updated successfully, but these errors were encountered: