Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search component fires a request after every keystroke #2062

Closed
manekenpix opened this issue Apr 1, 2021 · 2 comments · Fixed by #2066
Closed

Search component fires a request after every keystroke #2062

manekenpix opened this issue Apr 1, 2021 · 2 comments · Fixed by #2066
Assignees
@HyperTHD
Labels
type: bug Something isn't working
Milestone
1.9.5 Release

Comments

@manekenpix
Copy link
Member

After landing #2046, the search component fires a request after every keystroke instead of after hitting enter.
This behaviour is not desirable, and we should revert to the way the search component was working before this PR.
@manekenpix manekenpix added the type: bug Something isn't working label Apr 1, 2021
@manekenpix manekenpix added this to the 1.9.5 Release milestone Apr 1, 2021
@humphd
Copy link
Contributor

humphd commented Apr 1, 2021

Agree, this sounds like a regression (we had this fixed earlier).

cc @HyperTHD

@HyperTHD
Copy link
Contributor

HyperTHD commented Apr 1, 2021

Learnt my lesson. Gonna leave the PR up, even for weeks if it means it lands properly and fixed 👍🏾

@HyperTHD HyperTHD mentioned this issue Apr 1, 2021
Merged
8 tasks
HyperTHD added a commit that referenced this issue Apr 7, 2021
@HyperTHD
Merge pull request #2066 from HyperTHD/SearchBugFix
1f7dbd9 
Fixes: #2062: Search bar fires a request on every entered letter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HyperTHD HyperTHD

Labels
type: bug Something isn't working
Projects
None yet
Milestone
1.9.5 Release
Development

Successfully merging a pull request may close this issue.

Fixes: #2062: Search bar fires a request on every entered letter
3 participants
@humphd @HyperTHD @manekenpix