Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SearchHelp logic #1983

Closed
rjayroso opened this issue Mar 19, 2021 · 0 comments · Fixed by #2163
Closed

Improve SearchHelp logic #1983

rjayroso opened this issue Mar 19, 2021 · 0 comments · Fixed by #2163
Assignees
@rjayroso
Labels
area: front-end type: enhancement New feature or request

Comments

@rjayroso
Copy link
Contributor

What would you like to be added:
When there are no posts loaded in the SearchPage, the SearchHelp component should be visible. As it currently is, the SearchHelp can only be viewed on the initial viewing of the SearchPage, and after the first search is submitted, can no longer be viewed again until the page is refreshed.

Why would you like this to be added:
Although it is intended for the SearchHelp to disappear once the user searches, it would also be good for the user to see the SearchHelp anytime there are no posts loaded (i.e. if a user inputs a search that return no results OR if they clear the search bar, etc.)
rjayroso added a commit to rjayroso/telescope that referenced this issue Apr 16, 2021
@rjayroso
Fixes Seneca-CDOT#1983: Improve SearchHelp logic
e03c1c5
@rjayroso rjayroso mentioned this issue Apr 16, 2021
Merged
8 tasks
rjayroso added a commit to rjayroso/telescope that referenced this issue Apr 17, 2021
@rjayroso
Fixes Seneca-CDOT#1983: Improve SearchHelp logic
708e8d3
rjayroso added a commit that referenced this issue Apr 17, 2021
@rjayroso
Fixes #1983: Improve SearchHelp logic
f765b25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjayroso rjayroso

Labels
area: front-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1983: Improve SearchHelp logic rjayroso/telescope
1 participant
@rjayroso