Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning a newline character causes a syntax error in execute script #107

Closed
poftadeh opened this issue Dec 19, 2019 · 0 comments · Fixed by #132
Closed

Returning a newline character causes a syntax error in execute script #107

poftadeh opened this issue Dec 19, 2019 · 0 comments · Fixed by #132
Labels
Priority: Medium Type: Bug Something isn't working

Comments

@poftadeh
Copy link
Contributor

poftadeh commented Dec 19, 2019

What happened:
The script return '/n' causes an invalid syntax error in Execute Script Sync.

What you expected to happen:
For the endpoint to return \n

How to reproduce it (as minimally and precisely as possible):
Send { script: "return '\n'", args: [] } as the request body to the endpoint.

Anything else we need to know?:
dom.window.eval("return '\n'") also causes this error in plain Jsdom.

@poftadeh poftadeh added Type: Bug Something isn't working Priority: Medium labels Dec 19, 2019
poftadeh added a commit that referenced this issue Jan 15, 2020
fix: correct returning newlines in execute script sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant