Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/read errors #134

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Fix/read errors #134

merged 3 commits into from
Nov 4, 2024

Conversation

carschno
Copy link
Contributor

@carschno carschno commented Nov 4, 2024

  • Replace ValidationError with ValueError in Passage.Metadata, fixing error in constructor call.
  • Skip passages with invalid metadata
  • (unrelated) set valid fallback CORPUS_DIR path

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@carschno carschno merged commit 9d36c92 into main Nov 4, 2024
16 checks passed
@carschno carschno deleted the fix/read_errors branch November 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carschno