Fix for #614 #870
Open
Fix for #614 #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove whitespace (l. 141)
|
Thanks for your PR! At the moment, the changed file is not covered by any tests: https://app.codecov.io/gh/SemanticMediaWiki/SemanticResultFormats/blob/master/formats%2Fincoming%2FSRF_Incoming.php. Do you think you can add some testing? |
|
Apologies for the delay - I was hit with the man flu shortly afterwards. I can't currently find the time to add a test, but when I do, I can give it a try. Any guide we should be following? |
|
@D-Groenewegen ...take a look at the existing tests, maybe start with the JSONScript tests. There are also JSONScript tests in SMW itself. See also: https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #614. When no template is used, removes the html (a div element with the 'srf-incoming' class) from the result so that it allows for further reuse.