Support showing all rows as a length option in DataTables #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding -1 to datatables-lengthMenu, all rows can be shown
| // Replace -1 in lengthMenu with 'all' label | ||
| var showAll = options.lengthMenu.indexOf( -1 ); | ||
| if ( showAll !== -1 ) { | ||
| var labels = options.lengthMenu.slice(); |
There was a problem hiding this comment.
Need to clone the array so that the original options.lengthMenu wouldn't be altered.
I'm not sure what is the stance on ES6 in the project so I didn't use spread operators.
There was a problem hiding this comment.
so that the original options.lengthMenu wouldn't be altered.
Why?
There was a problem hiding this comment.
On Line 566, we set two arrays to the lengthMenu. The first array is for the numerical values (-1 represents all, which is the original values), the second array is for the label (all represents -1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
-1todatatables-lengthMenu, all rows can be shown.