Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticResultFormats datatables upgrade (KM-A) #730

Merged
merged 107 commits into from
Dec 21, 2022

Conversation

thomas-topway-it
Copy link
Contributor

@thomas-topway-it thomas-topway-it commented Sep 29, 2022

This PR is made in reference to: KM-A Knowledge Management Associates upgrade of SemanticResultFormats Datatables
This PR addresses or contains:

@krabina
Copy link
Contributor

krabina commented Dec 8, 2022

This PR is still work in progress. Will let you know when we are finished.

@krabina
Copy link
Contributor

krabina commented Dec 9, 2022

We believe or PR is ready now for integration. We improved the datatables format, fixed serveral bugs, added a new carousel format and provide php unit tests, json integration tests, and js QUnit tests.
We have tested on several production wikis on 1.35.
@JeroenDeDauw @gesinn-it-gea are we ready to merge?

@JeroenDeDauw JeroenDeDauw merged commit c2f9d91 into SemanticMediaWiki:master Dec 21, 2022
kghbln added a commit that referenced this pull request Dec 22, 2022
A follow-up to #730 

Fixes: #753
@kghbln kghbln mentioned this pull request Dec 22, 2022
@kghbln
Copy link
Member

kghbln commented Dec 22, 2022

JeroenDeDauw pushed a commit that referenced this pull request Dec 23, 2022
* Improve system messages

A follow-up to #730 

Fixes: #753

* Improve system messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment