-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListWidget: Remove usage of $this->mFormat
(not taken into account anymore by parent class)
#462
Conversation
This is supposed to test as rendered, i.e. with user interaction. I do not know how to test e.g. the "menu" widget with user interaction but probably this is not utmost necessary as long as "alphabet" and "pagination" work. |
I guess this is parser and not parser-html
You can only test the "raw" output of PHP not something JS creates after it has received the output because we cannot (or as easy as with PHP) test results from JS formats directly (you would need a headless browser and webdriver ... and so on).
|
@kghbln, if you don't mind, I will push a version, that should not require |
mFormat
that does not exist anymore$this->mFormat
(not taken into account anymore by parent class)
Fixed the format and the test. The test now only checks that the PHP part on the server produces the html structure that is expected by the JS on the client. |
Wow, this is really cool. Thank you a lot for your help. I am very grateful for this. |
@kghbln In case you confirmed that this is working as expected, feel free to merge! |
Affirmative, the field tests work cool as expected. |
…anymore by parent class) (#462) * ListWidget: ** Stop inheriting ListResultPrinter ** Provide tests
Back-ported with 14e04f1 |
This PR is made in reference to: #449
This PR addresses or contains:
mFormat
that does not exist anymoreThis PR includes:
Fixes #449