Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds json-ld serialization #80

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

thomas-topway-it
Copy link

@thomas-topway-it thomas-topway-it commented Jan 8, 2024

adds json-ld serialization using https://github.com/easyrdf/easyrdf
from SMW's standard RDF serialization

for testing purpose run composer install in the extension folder after merging the pull request #79

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 79.20%. Comparing base (4f1cce3) to head (2946b91).

Files Patch % Lines
src/JsonLDSerializer.php 0.00% 39 Missing ⚠️
src/HookRegistry.php 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #80       +/-   ##
=============================================
- Coverage     97.28%   79.20%   -18.08%     
- Complexity       67       80       +13     
=============================================
  Files             6        7        +1     
  Lines           184      226       +42     
=============================================
  Hits            179      179               
- Misses            5       47       +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krabina
Copy link

krabina commented Aug 3, 2024

@kghbln @JeroenDeDauw @gesinn-it-gea can we merge this?

@JeroenDeDauw
Copy link
Member

There is no automated test. Did someone manually test this?

@JeroenDeDauw
Copy link
Member

Some docs on expected behavior could also help. In the release notes or other documentation pages

@thomas-topway-it
Copy link
Author

ok, I will add a test, it won't take long

@krabina
Copy link

krabina commented Aug 3, 2024

I am using it on some wikis.

@krabina
Copy link

krabina commented Aug 4, 2024

I see two deprecation notices in MW 1.39:

Deprecated
: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in
/vendor/easyrdf/easyrdf/lib/Http/Response.php
on line
170


Deprecated
: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in
/vendor/easyrdf/easyrdf/lib/Http/Response.php
on line
174

@thomas-topway-it can you have a look, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants