Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryProcessor::getProcessedParams fix limit param #2474

Merged
merged 1 commit into from
May 21, 2017
Merged

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented May 21, 2017

This PR is made in reference to: #242

This PR addresses or contains:

  • Fix limit when the value is greater as the $smwgQMaxLimit, $smwgQMaxInlineLimit where it is reset to the default value despite the global limitation
{{#ask: [[Modification date::+]]
 |?Modification date
 |format=csv
 |limit=5000 --> resets to default 100 but should reset to $smwgQMaxInlineLimit
}}

{{#ask: [[Modification date::+]]
 |?Modification date
 |format=csv
 |limit=222 --> is within the $smwgQMaxInlineLimit
}}

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@mwjames mwjames merged commit e2e2cd6 into master May 21, 2017
@mwjames mwjames deleted the query-proc branch May 21, 2017 06:47
@mwjames
Copy link
Contributor Author

mwjames commented May 21, 2017

@mwjames
Copy link
Contributor Author

mwjames commented May 21, 2017

Back-ported to 2.5.x with d1ba666.

@kghbln
Copy link
Member

kghbln commented Sep 7, 2019

This is finally documented for both configuration parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants